Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit attribute count and truncate values in ElasticActivityListener #2461

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Oct 7, 2024

Implement limits to comply with OpenTelemetry specs, capping attributes at 128 and truncating string values to 10,000 characters. This ensures payload size remains manageable and adheres to the defined standards.

https://opentelemetry.io/docs/specs/otel/common/#attribute-limits

Implement limits to comply with OpenTelemetry specs, capping attributes at 128 and truncating string values to 10,000 characters. This ensures payload size remains manageable and adheres to the defined standards.

https://opentelemetry.io/docs/specs/otel/common/#attribute-limits
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit fb8e549 into main Oct 8, 2024
15 of 17 checks passed
@Mpdreamz Mpdreamz deleted the fix/max-attribute-protection branch October 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants