Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OTel bridge compatibility with existing Azure instrumentation #2455

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Sep 30, 2024

This ensures that the Azure SDK instrumentation doesn't use the existing Activity span ID, which, when combined with the OTel bridge, can lead to spans being parented by themselves.

This also enhances the logic of the OTel bridge so that we skip span creation for activities coming from the Azure SDK libraries if our Azure instrumentation assemblies are loaded. This ensures we don't create essentially repeated child spans.

Fixes #2452

Mpdreamz
Mpdreamz previously approved these changes Oct 2, 2024
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevejgordon stevejgordon merged commit 5b94344 into main Oct 4, 2024
14 of 16 checks passed
@stevejgordon stevejgordon deleted the fix-servicebus-instrumentation branch October 4, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Azure ServiceBus traces are broken in some situations
2 participants