Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duration.sum.us value in JSON #2219

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix duration.sum.us value in JSON #2219

merged 2 commits into from
Nov 10, 2023

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Nov 9, 2023 •
edited
Loading

Fixes #2200

@stevejgordon
Fix duration.sum.us value in JSON
4287823
@stevejgordon
Fix logic in Elastic.Apm.Feature.Tests
7f0f750 
This was previously modified causing some tests to fail. This reverts that change as I'm not sure why it was included.
@stevejgordon
Copy link
Contributor Author

@Mpdreamz in 7f0f750 I reverted a change you made which seems to cause test failures for me on Windows and Linux. Can you recall the reason for the change you made?

gregkalapos
gregkalapos approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevejgordon stevejgordon merged commit f7f52ae into main Nov 10, 2023
14 checks passed
@stevejgordon stevejgordon deleted the bug/2200 branch November 10, 2023 09:21
@Mpdreamz
Copy link
Member

@Mpdreamz in 7f0f750 I reverted a change you made which seems to cause test failures for me on Windows and Linux. Can you recall the reason for the change you made?

I do not. The only thing that sprung to mind was #2180 but that is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregkalapos gregkalapos gregkalapos approved these changes

Assignees
No one assigned
Labels
agent-dotnet
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error from intake API for dropped_spans_stats: "can not decode float as int"
3 participants
@stevejgordon @Mpdreamz @gregkalapos