Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): suppress memory leaks in libJANA.so and DD4hep #1637

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(ci): suppress memory leaks in libJANA.so and DD4hep #1637

merged 2 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. fix(ci): suppress memory leaks in libJANA.so (#1628) 

    ### Briefly, what does this PR introduce?
Since a week or so, CI jobs on `main` have been failing,
https://github.com/eic/EICrecon/actions/workflows/linux-eic-shell.yml?query=branch%3Amain.
First one was https://github.com/eic/EICrecon/actions/runs/11171861991.
This appears to be due to LSan in libJANA.so, e.g.
https://github.com/eic/EICrecon/actions/runs/11171861991/job/31058015623#step:9:3979:
```
=================================================================
==609==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 272 byte(s) in 2 object(s) allocated from:
    #0 0x55e2fb0ba20d in operator new(unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e20d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2)
    #1 0x7f2d2a6a06d1 in JStreamLog::JStreamLog(std::ostream const&, char const*) (/opt/local/lib/libJANA.so+0x15d6d1) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c)

Indirect leak of 21 byte(s) in 2 object(s) allocated from:
    #0 0x55e2fb0ba31d in operator new[](unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e31d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2)
    #1 0x7f2d2a6a13dd in JStreamLogBuffer::JStreamLogBuffer(std::basic_streambuf<char, std::char_traits<char>>*, char const*) (/opt/local/lib/libJANA.so+0x15e3dd) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c)
```

This PR ignores memory leaks in libJANA.so.

### What kind of change does this PR introduce?
- [x] Bug fix (issue:
https://github.com/eic/EICrecon/actions/runs/11171861991/job/31058015623#step:9:3979)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators: @nathanwbrei
(please tag me on a JANA issue and fix so we can remove this again here)

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

(cherry picked from commit c92c8e0)
    @wdconinc @github-actions
    wdconinc authored and github-actions[bot] committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    eb2f51f View commit details
    Browse the repository at this point in the history

  2. suppress dd4hep leak

    @veprbl
    veprbl authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b182a16 View commit details
    Browse the repository at this point in the history