Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: List 2.0 #76

Merged
merged 43 commits into from
Aug 7, 2024
Merged

feat: List 2.0 #76

merged 43 commits into from
Aug 7, 2024

Conversation

e11sy
Copy link

@e11sy e11sy commented Aug 2, 2024

This PR is related to the #75 issue
This PR is a part of global work on List 2.0

Problems

  • Can not convert from list to check list
  • Data model has no place for meta (e.g. checked field for checklist)
  • Nesting is not customizable
  • Can not increase nesting more than 1 time
1
    1.1.1

is currently unavailable

  • Can't customize ordered list (custom numeration or starting with custom number)

Solutions

  • Separated rendering and tabulation for greater compliance with the SPR model
  • Now ones list style would be changed, list would be rerendered
  • Now data model will contain meta field
data : {
  items : [
    {
      "content": "Canon",
      "meta" : {
        checked: false
       },
      "items": [
        {
          "content": "Fisheye",
          "meta" : {
            checked: true
          },
          "items": [
            {
              "content": "Canon 15mm f/2.8",
              "meta" : {
                checked: true
              },
              "items": []
            },
          ]
        }
      ]
    } 
  ]
}   
  • Nesting customization by maxLevel config option
  • Add support for <ol> attributes in config (such as type, start, reversed)

Status

Additional

  • Added index.html file and updated vite.config.js, so now dev mode is available
  • Updated @codexteam/icons package to latest for checklist icon

I will make ordered list and nesting customizations, refactoring of the paste config and nesting behaviour in the following prs

@e11sy e11sy changed the base branch from main to release/2.0 August 3, 2024 16:29
src/ListRenderer/checklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/checklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/checklistRenderer.ts Outdated Show resolved Hide resolved
src/types/itemMeta.ts Outdated Show resolved Hide resolved
src/ListRenderer/checklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/unorderedListRenderer.ts Outdated Show resolved Hide resolved
src/ListTabulator/index.ts Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
@e11sy e11sy requested a review from neSpecc August 3, 2024 18:42
src/ListRenderer/checklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/ChecklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/OrderedListRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/OrderedListRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/UnorderedListRenderer.ts Outdated Show resolved Hide resolved
@e11sy e11sy requested a review from neSpecc August 6, 2024 16:16
src/ListRenderer/ChecklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/ChecklistRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/OrderedListRenderer.ts Outdated Show resolved Hide resolved
src/ListRenderer/ChecklistRenderer.ts Outdated Show resolved Hide resolved
src/ListTabulator/index.ts Outdated Show resolved Hide resolved
src/ListTabulator/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/types/itemMeta.ts Outdated Show resolved Hide resolved
src/types/listParams.ts Outdated Show resolved Hide resolved
styles/i.html Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
styles/index.pcss Outdated Show resolved Hide resolved
@e11sy e11sy merged commit d14575d into release/2.0 Aug 7, 2024
1 check passed
@e11sy e11sy deleted the List-2.0 branch August 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants