fix: update debian packaging #752
Open
+29
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
diogomatsubara
commented
Oct 19, 2024
diogomatsubara
commented
- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode
|
PR missing one of the required labels: {'dependencies', 'documentation', 'breaking-change', 'new feature', 'internal', 'enhancement', 'bug'} |
sashacmc
suggested changes
Oct 19, 2024
| set(project_version "${project_version}-dev") | ||
| elseif(PROJECT_VERSION_TWEAK GREATER 1) | ||
| set(debian_version "${project_version}~pre.${PROJECT_VERSION_TWEAK}-1") |
There was a problem hiding this comment.
It is not entirely clear for me what this -1 means and why it is hardcoded.
There was a problem hiding this comment.
To comply with the debian version policy.
There was a problem hiding this comment.
Unlikely, so far we haven't had any reason to change it. In case we need to change in a further date I can make it default to -1 and allow the user to set a value.
- include libzenohpico.so in debian package - change the package name to libzenohpico in line with libzenohc - set correct debian version for pre releases - fix wrong version used in Release mode
diogomatsubara
force-pushed
the
fix-pico-debian-package
branch
from
fba07a9
to
2935b0d
Compare
|
I rebased on top of Denis's PR #751 which handles the |
sashacmc
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.