API alignment #731
Merged
API alignment #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sashacmc
commented
Oct 10, 2024
•
sashacmc
commented
- Rename z_publisher_declare to z_declare_publisher and make session first
- Rename z_subscriber_declare to z_declare_subscriber and make session first
- Rename z_queryable_declare to z_declare_queryable and make session first
- Move a session as the first parameter for z_declare_keyexpr/z_undeclare_keyexpr
- Return undeclare method for publisher/subscriber/queryable
|
PR missing one of the required labels: {'enhancement', 'breaking-change', 'internal', 'new feature', 'dependencies', 'bug', 'documentation'} |
sashacmc
added
api sync
sashacmc
added
internal
| @@ -1899,7 +1921,7 @@ z_result_t z_keyexpr_from_substr_autocanonize(z_owned_keyexpr_t *keyexpr, const | |||
| * Return: | |||
| * ``0`` if declare is successful, ``negative value`` otherwise. | |||
| */ | |||
| z_result_t z_declare_keyexpr(z_owned_keyexpr_t *declared_keyexpr, const z_loaned_session_t *zs, | |||
| z_result_t z_declare_keyexpr(const z_loaned_session_t *zs, z_owned_keyexpr_t *declared_keyexpr, | |||
There was a problem hiding this comment.
need to update order of arguments in the docs
| @@ -1912,7 +1934,7 @@ z_result_t z_declare_keyexpr(z_owned_keyexpr_t *declared_keyexpr, const z_loaned | |||
| * Return: | |||
| * ``0`` if undeclare is successful, ``negative value`` otherwise. | |||
| */ | |||
| z_result_t z_undeclare_keyexpr(z_moved_keyexpr_t *keyexpr, const z_loaned_session_t *zs); | |||
| z_result_t z_undeclare_keyexpr(const z_loaned_session_t *zs, z_moved_keyexpr_t *keyexpr); | |||
There was a problem hiding this comment.
need to update order of arguments in the docs
milyin
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.