Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"docker rmi " of 'FROM' docker fails now #235

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Aug 3, 2023

Since today it seems that base docker image (the one which was used in "FROM" clause) doesn't appear in the list of the images. Attempt to remove it causes build failure.
Removed command "dorcker rmi" for this image to fix the build failure.

@milyin milyin requested a review from Mallets August 3, 2023 11:42
Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we fix the image being fetched instead?

@Mallets
Copy link
Member

Mallets commented Aug 3, 2023

I've reproduced the same behaviour on an Ubuntu machine. It seems that Docker behaviour changed and the image does not appear anymore on the image list and docker rmi fails. Nevertheless, the whole crossbuilding process is successful. Therefore, I'm in favour for approving this PR. @cguimaraes ?

@Mallets Mallets merged commit 5cbe35a into master Aug 3, 2023
54 checks passed
@Mallets Mallets deleted the docker_rmi_from_fail branch August 3, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants