Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make keyexpr functions standalone #64

Merged
merged 4 commits into from
Sep 6, 2023
Merged

make keyexpr functions standalone #64

merged 4 commits into from
Sep 6, 2023

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Aug 26, 2023

proposed fix for #63

@milyin milyin changed the title Keyexpr compare out make keyexpr functions standalone Aug 26, 2023
p-avital
p-avital requested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@p-avital p-avital left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add links to the Key Expression RFC in the docstrings before merging?

@milyin
Copy link
Contributor Author

milyin commented Sep 6, 2023

Could you add links to the Key Expression RFC in the docstrings before merging?

Done

@milyin milyin merged commit 2093a78 into main Sep 6, 2023
4 checks passed
@milyin milyin deleted the keyexpr_compare_out branch September 6, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-avital p-avital p-avital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milyin @p-avital