Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce query channels #222

Merged
merged 5 commits into from
Dec 18, 2023
Merged

introduce query channels #222

merged 5 commits into from
Dec 18, 2023

Conversation

p-avital
Copy link
Contributor

@p-avital p-avital commented Dec 14, 2023

Since owned queries now exist, channels to allow moving them around would be useful.

@p-avital p-avital requested a review from milyin December 14, 2023 16:17
Cargo.toml Outdated Show resolved Hide resolved
@Mallets
Copy link
Member

Mallets commented Dec 15, 2023

It generally looks good to me. However, can you add an example on how to use z_owned_query_t? For both channel and non-channel based API.

@Mallets
Copy link
Member

Mallets commented Dec 16, 2023

It seems there is a merge conflict on include/zenoh_commons.h

*/
typedef struct z_owned_query_t {
void *_0;
} z_owned_query_t;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per-naming convention, z_x means that is also available in zenoh-pico. However, this feature will initially only available in zenoh-c... should it (and all related functions) be called zc_?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan was originally to introduce these symbols in pico during the release... They should arrive soon, but we could rename these for now until pico has them too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename would introduce a small break in zenoh-cpp, which would be a thorn in the release's side, so let's keep the z_ prefix, with the goal of having pico finish up implementation by mid-January.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the name then to avoid excessive back-and-forth.

@Mallets Mallets merged commit a2209b7 into master Dec 18, 2023
7 checks passed
@Mallets Mallets deleted the query-channels branch December 18, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants