-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce query channels #222
Conversation
It generally looks good to me. However, can you add an example on how to use |
It seems there is a merge conflict on |
*/ | ||
typedef struct z_owned_query_t { | ||
void *_0; | ||
} z_owned_query_t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per-naming convention, z_x
means that is also available in zenoh-pico
. However, this feature will initially only available in zenoh-c
... should it (and all related functions) be called zc_
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan was originally to introduce these symbols in pico during the release... They should arrive soon, but we could rename these for now until pico has them too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename would introduce a small break in zenoh-cpp, which would be a thorn in the release's side, so let's keep the z_
prefix, with the goal of having pico finish up implementation by mid-January.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the name then to avoid excessive back-and-forth.
Since owned queries now exist, channels to allow moving them around would be useful.