Update to the latest up-python (up-spec v1.6.0-alpha.2) #10
Conversation
There was a problem hiding this comment.
@neelam-kushwah I also made some changes on up-transport-zenoh-rust recently. Perhaps you want to take a look at the recent changes.
up_client_zenoh/zenohutils.py
Outdated
| | [8000-FFFF) | FFFF | | V | | | | ||
| | FFFF | FFFF | | V | V | V | | ||
|
|
||
| Some organization: |
There was a problem hiding this comment.
There are some changes on the table, and you can link to here
https://github.com/eclipse-uprotocol/up-spec/tree/main/up-l1#23-registerlistener
There was a problem hiding this comment.
As per the latest changes in spec, using a wildcard source with a sink in the RPC range is now considered an invalid combination where as L2 apis uses this combination for request message type.
| else: | ||
| common_uuri.logging.debug("Failed to get result from invoke_method.") | ||
| common_uuri.logging.debug(f"Send request to {uuri}") | ||
| rpc_client = InMemoryRpcClient(transport) |
There was a problem hiding this comment.
In fact, I implemented my own RpcClient for Rust implementation, which uses get() in Zenoh directly. I'm not sure whether you want to do the same thing in Python or not. Both are fine with me, so I leave the decision to you.
There was a problem hiding this comment.
Since the transport layer provides three APIs, I focused on implementing only those in the Zenoh transport. The default RPC implementation in the communication layer handles RPC requests and responses effectively, so I avoided creating a separate RPC client implementation as it isn't necessary.
| rpc_server.register_listener(uuri, RPCRequestListener()) | ||
| async def register_rpc(): | ||
| uuri = create_method_uri() | ||
| rpc_server = InMemoryRpcServer(transport) |
There was a problem hiding this comment.
In my Rust examples, I use L1 API to show how to send request and response. I also provide the L2 API for client one. Maybe you also want to offer examples of L1 API.
There was a problem hiding this comment.
LGTM
For the resource ID table, @neelam-kushwah could you please take a look at my recent PR? Let me know whether this works for you or not.
#11