fix: #7 fixed unit tests #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
unit tests are not executed in action. Reason could be, that the maven build in the GitHub action is using surefire plugin 2.x.x, and locally I am using 3.2.5. Todo: Further investigation needed, why there is a mismatch in the default versions of maven plugins, fix the root cause and get coverage displayed here |
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
testcoverage fixed, ready for review |
evshary
approved these changes
Sep 3, 2024
sophokles73
reviewed
Sep 23, 2024
| private static final String USER_PROPERTIES_KEY_FOR_TOKEN = "10"; | ||
| private static final String USER_PROPERTIES_KEY_FOR_TRACEPARENT = "11"; | ||
| private static final String USER_PROPERTIES_KEY_FOR_PAYLOAD_FORMAT = "12"; | ||
| public static final Logger LOG = LoggerFactory.getLogger(HiveMqMQTT5Client.class); |
There was a problem hiding this comment.
why do you need/want to make the logger public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.