Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide improved support for long property values #1874

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 10, 2024

  • Make the MavenPropertyDialog resizeable and provide dialog settings to remember the size.
  • Use a table layout for the property table of the MavenLaunchMainTab.

- Make the MavenPropertyDialog resizeable and provide dialog settings to
remember the size.
- Use a table layout for the property table of the MavenLaunchMainTab.
@merks
Copy link
Contributor Author

merks commented Oct 10, 2024

I literally needed to edit a value in some other editor and paste it because it just wasn't possible with the tiny limited-sized dialog:

image

The table layout also improves the use of the existing real estate.

@merks
Copy link
Contributor Author

merks commented Oct 10, 2024

A more realistic value that I was editing is like this one:

${file_extract_matching_pattern:${platform-dependencies}/pom.xml,UTF-8,<version.maven.tycho>([^<]+)</version.maven.tycho>,$1,3.0.1}

I'm experimenting with a dynamic variable where I can specify a file to be read with the given encoding, a pattern that's used to find a match in the content, a replacement string used to extract the content, and a default value if the pattern doesn't match. It's quite a bit to specify!

image

Copy link

Test Results

  321 files  ±0    321 suites  ±0   51m 9s ⏱️ - 4m 16s
  678 tests ±0    657 ✅  - 1  18 💤 ±0  2 ❌ +1  1 🔥 ±0 
2 034 runs  ±0  1 977 ✅  - 1  54 💤 ±0  2 ❌ +1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 9be0f9b. ± Comparison against base commit 51c902c.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@laeubi laeubi merged commit 99d6e7e into eclipse-m2e:master Oct 11, 2024
7 of 8 checks passed
@merks merks deleted the pr-long-properties branch October 11, 2024 06:02
@HannesWell
Copy link
Contributor

Thank you for this one as well.

If one want's to enhance M2E's launch dialog further I think it would be good if one could edit property keys and values directly in the table without the need of a separate dialog at all.

@merks
Copy link
Contributor Author

merks commented Oct 12, 2024

Yes, as well up and down buttons. I know order doesn't matter, but it's still nice to organize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants