This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Make datapoints editable (remove/add) on the fly #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
force-pushed
the
feature/mock_editable
branch
from
edaeb92
to
950430a
Compare
|
@doosuu could you review :) |
lukasmittag
force-pushed
the
feature/mock_editable
branch
from
950430a
to
fd4957d
Compare
doosuu
suggested changes
Oct 9, 2023
|
will add some tests too (soon) |
|
Bit off topic from the ticket feature but since this introduced some hiccups when starting the mock service on a Mac at first... we managed to solve those issues. So the basic interactions are working also on a Mac with this branch. However I had to:
So that part looks good for me. |
SebastianSchildt
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes addition and removal for mocked datapoints during runtime available. It is used by the Web UI and tkinter GUI.