Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Mock service leveraging kuksa client lib #88

Conversation

lukasmittag
Copy link
Contributor

This PR leverages kuksa-client lib instead of pure grpc and protobuf files. It fixes too the EventTrigger on values.

@lukasmittag lukasmittag force-pushed the feature/mock_with_kuksa_client_lib branch 2 times, most recently from 7b973c2 to 4786b0f Compare July 26, 2023 07:54
@lukasmittag lukasmittag force-pushed the feature/mock_with_kuksa_client_lib branch from 4786b0f to 0992991 Compare July 26, 2023 08:04
@lukasmittag lukasmittag marked this pull request as ready for review July 31, 2023 11:45
@SebastianSchildt
Copy link
Contributor

@doosuu can you check whether this works/seems reasonable

mock_service/README.md Outdated Show resolved Hide resolved
mock_service/lib/action.py Outdated Show resolved Hide resolved
mock_service/lib/behavior.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/dsl.py Outdated Show resolved Hide resolved
mock_service/lib/types.py Outdated Show resolved Hide resolved
mock_service/mock.py Outdated Show resolved Hide resolved
doosuu
doosuu approved these changes Aug 9, 2023
Copy link
Contributor

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rework findings.

@lukasmittag
Copy link
Contributor Author

CI failing due to reformatting of docs with pre-commit hooks.

Copy link
Contributor

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my latest comments

@doosuu
Copy link
Contributor

doosuu commented Aug 21, 2023

LGTM

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like
image

@SebastianSchildt SebastianSchildt merged commit e4d4fde into eclipse-kuksa:main Aug 22, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants