Introduce robust URL to java.nio.file.Path conversion #691
Conversation
| * | ||
| * @since 3.20 | ||
| */ | ||
| public static Path toFilePath(URL url) { |
There was a problem hiding this comment.
That the name contains File and Path seems to be a duplication at first, but since any kind of URL can have a path I think it should be made clear that it's a file-system path (although nio-Path can also handle non-classical file-systems).
On the other hand toFileSystemPath() seemed to be a bit verbose to me.
There was a problem hiding this comment.
Only food for thought, this suggestion isn't common convention. Could use Path fromFileUrl(URL url).
Cannot say I like that, but it seems to make it clear.
| if (!SCHEME_FILE.equals(url.getProtocol())) { | ||
| throw new IllegalArgumentException("Not a 'file' url: " + url); //$NON-NLS-1$ | ||
| } |
There was a problem hiding this comment.
Alternatively this method could return an empty optional if the URL is not a file-URL.
But since callers that are able to handle other protocols can simple check the precondition before calling this method, I think it's fine to keep it simple for those cases where a file-URL is used with certainty.
Converting a URL into a
PathorFileis not a trivial task, especially since URLs are often malformed and therefore the straight forward wayPath.of(url.toURI())ornew File(url.toURI())lead to aURISyntaxExceptionbeing thrown. Therefore multiple different workarounds are used throughout the SDK, e.g.Path.of(url.getPath())orPath.of(url.getFile()), but they are again have their problems.This PR suggest a new utility method in the
URIUtilthat is capable of all the different conversion methods and workarounds and has the goal to reliably convertfile-URLs intojava.nio.file.Paths regardless of if the URL is malformed or perfectly complying to the standard.This could also help for eclipse-platform/eclipse.platform#35 because one does not have to rely on malformed URLs anymore if they are just passed around internally (URLs displayed to the user are another topic).