Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developed controllers for power-heat coupled network and plot it #653

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sf-snigdha
Copy link

developed controllers for power-heat coupled network and plot it

Added multinetwork with power and heat networks , developed their simple controller according to the power to gas network and tried to plot the coupled network.
@EPrade
Copy link
Contributor

EPrade commented Oct 15, 2024

Hey, cool that your idea resulted in this pull request. It is always a joy to welcome new contributers here!
The code looks good on the first glance. However the files could be sorted into seperate folders to fit the pandapipes structure. Maybe you can restructure the files and the we finalize this PR.

  • the multinet controller would fit into the directory pandapipes/multinet/control
  • the example/tutorial should be changed into a jupyter notebook and would then fit in the tutorial folder
  • the plotting code can be moved to the plotting folder

Please ask if you have any questions.
Looking forward to more great contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants