Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t_outlet in pipe results #648

Merged
merged 7 commits into from
Aug 27, 2024
Merged

t_outlet in pipe results #648

merged 7 commits into from
Aug 27, 2024

Conversation

EPrade
Copy link
Contributor

@EPrade EPrade commented Aug 25, 2024

First draft:

  • not sure if res_branch_ht is needed at all as an argument in the def extract_branch_results_with_internals() function.
  • for extract_branch_results_with_internals() I just put the t_outlet section extra at the bottom

@EPrade EPrade requested a review from dlohmeier August 25, 2024 12:11
@EPrade EPrade marked this pull request as ready for review August 26, 2024 13:28
Copy link
Collaborator

@dlohmeier dlohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great addition for result handling. Could you add a change to the log?

dlohmeier
dlohmeier previously approved these changes Aug 27, 2024
Copy link
Collaborator

@dlohmeier dlohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@EPrade EPrade merged commit 66a6670 into e2nIEE:develop Aug 27, 2024
29 checks passed
@EPrade EPrade deleted the feature/t_outlet branch August 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants