Move read bytes utilities to Encoding #558
Conversation
| byte[] bytes = new byte[length]; | ||
| try { | ||
| readBytes(buffer, bytes); | ||
| } catch (BufferUnderflowException e) { |
There was a problem hiding this comment.
This catch shouldn't be needed as readBytes already checks the length.
Or we could replace the checks in those read methods with handling for BufferUnderflowException.
| return readName(buffer, true); | ||
| } | ||
|
|
||
| public static String readName(ByteBuffer buffer, boolean checkMalformed) { |
There was a problem hiding this comment.
Nit: copy Javadoc from above or make it @see the above
|
|
||
| /** | ||
| * Read a symbol name from the buffer as UTF-8 String. | ||
| * See <a href="https://www.w3.org/TR/wasm-core-1/#names%E2%91%A0">2.2.4. Names</a> of the WebAssembly Core Specification. |
There was a problem hiding this comment.
The link is broken: the extra %E2%91%A0 at the end of the URL shouldn't be there.
There was a problem hiding this comment.
good catch, fixed!
| @@ -11,6 +13,126 @@ public final class Encoding { | |||
|
|
|||
| private Encoding() {} | |||
|
|
|||
| static int readInt(ByteBuffer buffer) { | |||
There was a problem hiding this comment.
Do these need to be public? Could they be needed for parsing custom sections?
This is just a question to consider. It's fine to leave them private for now.
There was a problem hiding this comment.
In the current status I think that there are quite a few changes necessary to offer a proper, usable and generic API to parse custom sections ...
I would not try to predict the future, and welcome effort in this direction when someone needs it.
Opening visibility is not going to be a breaking change.
Fix #521