Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize AOT CALL_INDIRECT for calls in the same module #555

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Optimize AOT CALL_INDIRECT for calls in the same module #555

merged 4 commits into from
Oct 3, 2024

Conversation

electrum
Copy link
Collaborator

@electrum electrum commented Oct 2, 2024

No description provided.

@electrum
Remove unnecessary catch for ASM verifier
bb8e75c 
We now include asm-util as a required dependency.
Record any exception as it may be helpful for debugging.
@electrum electrum requested a review from andreaTP October 2, 2024 22:55
andreaTP
andreaTP approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, easy to read and straightforward.

LGTM, thanks a lot as always!

@andreaTP andreaTP merged commit 6c40a05 into dylibso:main Oct 3, 2024
13 checks passed
@electrum electrum deleted the callindirect branch October 3, 2024 17:37
@electrum electrum mentioned this pull request Oct 3, 2024
Merged
@andreaTP andreaTP mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@electrum @andreaTP