AM/PM Merged, Updated, Fixed #54
Open
+347
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'ampm' of https://github.com/JamesMcIntosh/flutter-cupertino-date-picker # Conflicts: # lib/src/widget/datetime_picker_widget.dart # lib/src/widget/time_picker_widget.dart
|
@dylanwuzh can we get this merged? 👍 |
|
@rdev-software I'm seeing an issue where when I attempt to scroll any of the wheels, the hours disappear. See video here: https://share.getcloudapp.com/nOumbNvl Here's the code I'm using: DatePicker.showDatePicker(
context,
initialDateTime: initialValue,
dateFormat: 'MMM dd, yyyy|hh|mm|a',
minDateTime: DateTime.now(),
pickerMode: DateTimePickerMode.datetime,
onConfirm: (v, _) {
selectedDateTime = v;
controller.text = formatDateTime(v);
Vibrate.feedback(FeedbackType.success);
},
);Are you experiencing this? |
|
If I change the |
|
Would love to see this merged and available soon. Thanks for the enhancement! |
added 2 commits
June 17, 2020 10:09
…no-date-picker into ampm # Conflicts: # lib/src/widget/datetime_picker_widget.dart
|
@dylanwuzh Can this get merged? |
This removes DiagnosticableMixin, since it is a duplicate implementation of Diagnosticable. It existed in order to support plugins that wanted to support both master and stable, but now Diagnosticable is a mixin on stable, so we don't need it anymore.
|
Hi is this implemented in the production? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AM/PM feature to time picker and datetime picker
#35
Used code from PR #49
Retested, Added missing features and fixed some bugs with datetime picker