Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208262570807667/f
Description:
This change adds pixels for tracking NTP Search Box experiment.
Steps to test this PR:
DefaultNewTabPageSearchBoxExperimentCohortDecider.cohort
to return.control
.experiment
cohort.Verifying experiment pixel:
m_mac_initial-search
.m_mac_initial-search-day-1
is sent with acount = 1
andfrom = ntp_search_bar
m_mac_initial-search-day-1
is sent with acount = 2
andfrom = ntp_address_bar
m_mac_initial-search-day-1
is sent with acount = 3
andfrom = address_bar
count = 10
m_mac_initial-search-day-2
is sent with acount = 1
and appropriate from parameter.Verifying autocomplete pixel parameters:
m_mac_autocomplete_*
) with the correctfrom
parameter, and the experiment cohort.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation