Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one-click Fire Button setting #2968

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

one-click Fire Button setting #2968

wants to merge 1 commit into from

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204517122485752/1204517122517075/f

Description:

  • Add setting to make the Fire Button one-click shot

Steps to test this PR:

  1. Open Settings->Data Clearing in 2 windows
  2. Activate one-click Fire Button setting, validate it‘s changed in both windows
  3. Click the fire button – fire animation should run instantly removing all data

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from tomasstrba July 12, 2024 10:45
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected. 👍

I'd change the section name to "Fire Button"

@@ -41,7 +41,19 @@ extension Preferences {

}

// SECTION 2: Fireproof Site
// SECTION: Fire Window
PreferencePaneSection(UserText.dataClearing) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to change the section name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants