Add missing SPARKLE checks

duckduckgo · Sep 25, 2024 · 3f91338 · 3f91338
1 parent 92c756a
commit 3f91338
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift b/DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift
@@ -410,10 +410,12 @@ final class MoreOptionsMenu: NSMenu, NSMenuDelegate {
     }
 
     func menuWillOpen(_ menu: NSMenu) {
+#if SPARKLE
         guard let updateController = Application.appDelegate.updateController else { return }
         if updateController.hasPendingUpdate && updateController.needsNotificationDot {
             updateController.needsNotificationDot = false
         }
+#endif
     }
 }
 

diff --git a/DuckDuckGo/NavigationBar/View/MoreOptionsMenuButton.swift b/DuckDuckGo/NavigationBar/View/MoreOptionsMenuButton.swift
@@ -63,12 +63,14 @@ final class MoreOptionsMenuButton: MouseOverButton {
     }
 
     private func subscribeToUpdateInfo() {
+#if SPARKLE
         guard let updateController else { return }
         cancellable = Publishers.CombineLatest(updateController.hasPendingUpdatePublisher, updateController.notificationDotPublisher)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] hasPendingUpdate, needsNotificationDot in
                 self?.isNotificationVisible = hasPendingUpdate && needsNotificationDot
             }
+#endif
     }
 
     private func setupNotificationLayerIfNeeded() {

diff --git a/DuckDuckGo/Preferences/Model/AboutPreferences.swift b/DuckDuckGo/Preferences/Model/AboutPreferences.swift
@@ -41,9 +41,11 @@ final class AboutPreferences: ObservableObject, PreferencesTabOpening {
 
     @Published var updateState = UpdateState.upToDate
 
+#if SPARKLE
     var updateController: UpdateControllerProtocol? {
         return Application.appDelegate.updateController
     }
+#endif
 
     var areAutomaticUpdatesEnabled: Bool {
         get {

diff --git a/DuckDuckGo/Preferences/View/PreferencesAboutView.swift b/DuckDuckGo/Preferences/View/PreferencesAboutView.swift
@@ -144,9 +144,11 @@ extension Preferences {
             }
         }
 
+#if SPARKLE
         private var hasPendingUpdate: Bool {
             model.updateController?.hasPendingUpdate == true
         }
+#endif
 
         @ViewBuilder
         private var versionText: some View {