Add CMPs #492
Open
Add CMPs #492
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seia-soto
changed the title
muodov
reviewed
Oct 9, 2024
| ], | ||
| "optOut": [ | ||
| { | ||
| "click": "#consent-manager div > button[class]:first-child" |
There was a problem hiding this comment.
I tried it just now, and the reject button is actually the second child. Could you double check? If the button position is not consistent, we may need another way to select. You could use an XPath selector to check a specific text, or maybe check for that style attribute
| ], | ||
| "optOut": [ | ||
| { | ||
| "waitForThenClick": "#accept-consent-all" |
There was a problem hiding this comment.
Judging by the class names, the rules should be reversed: accept-consent-all in optIn, and accept-consent-necessary in optOut
| "name": "mediapart-fr", | ||
| "vendorUrl": "https://www.mediapart.fr/", | ||
| "runContext": { | ||
| "urlPattern": "^https://(www)\\.mediapart\\.fr" |
There was a problem hiding this comment.
Are you sure this is a site-specific popup? The selectors look pretty generic, should we enable them for more sites?
Comment on lines
+26
to
+31
| { | ||
| "waitForThenClick": ".cookie-dialog .content .cookie-option-large span" | ||
| }, | ||
| { | ||
| "waitForThenClick": ".cookie-dialog .content button[type='submit']" | ||
| } |
There was a problem hiding this comment.
This fails for me when I browser from NL. Did the HTML structure change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ghostery/broken-page-reports#851
refs ghostery/broken-page-reports#847
refs ghostery/broken-page-reports#848
refs ghostery/broken-page-reports#166
refs ghostery/broken-page-reports#203