Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test consolidation with parameterized test fixtures #21

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Test consolidation with parameterized test fixtures #21

merged 3 commits into from
Feb 11, 2021

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Feb 11, 2021

This partly addresses #20 by testing against static rendered DOT files.

Testing against SVG and PNG outputs seems like it'll take some more effort later. For whatever reason, the Ubuntu CI environment generates some different files. (The DOT file had whitespace differences, addressed by parsing with pygraphviz.) Will update #20 to be about the image files.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #21 (4356bc1) into main (bcb312b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #21   +/-   ##
=====================================
  Coverage   98.1%   98.1%           
=====================================
  Files         13      13           
  Lines        422     422           
=====================================
  Hits         414     414           
  Misses         8       8           

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant