Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CreateJobCount and CreateJobSuccessCount metrics #3588

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Oct 18, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 18, 2024
@gaius-qi gaius-qi self-assigned this Oct 18, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 18, 2024 03:00
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.93%. Comparing base (030f337) to head (ef0d9ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/service/job.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
- Coverage   36.33%   35.93%   -0.41%     
==========================================
  Files         335      335              
  Lines       31112    36848    +5736     
==========================================
+ Hits        11305    13241    +1936     
- Misses      18970    22768    +3798     
- Partials      837      839       +2     
Flag Coverage Δ
unittests 35.93% <25.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/handlers/job.go 60.00% <100.00%> (-3.86%) ⬇️
manager/metrics/metrics.go 100.00% <ø> (ø)
manager/service/job.go 0.00% <0.00%> (ø)

... and 260 files with indirect coverage changes

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CormickKneey CormickKneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 2793851 into main Oct 18, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/job branch October 18, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants