Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate SBOM for release artifacts #3585

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: generate SBOM for release artifacts #3585

merged 1 commit into from
Oct 17, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Oct 17, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 17, 2024
@gaius-qi gaius-qi self-assigned this Oct 17, 2024
@gaius-qi gaius-qi requested review from a team as code owners October 17, 2024 13:16
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 1bad8a8 into main Oct 17, 2024
19 of 25 checks passed
@gaius-qi gaius-qi deleted the feature/sbom branch October 17, 2024 13:20
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (5c52a02) to head (a19d2e1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3585      +/-   ##
==========================================
- Coverage   36.34%   36.32%   -0.02%     
==========================================
  Files         335      335              
  Lines       31112    31112              
==========================================
- Hits        11308    11302       -6     
- Misses      18967    18971       +4     
- Partials      837      839       +2     
Flag Coverage Δ
unittests 36.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@gaius-qi gaius-qi restored the feature/sbom branch October 17, 2024 14:00
gaius-qi added a commit that referenced this pull request Oct 17, 2024
gaius-qi added a commit that referenced this pull request Oct 17, 2024
Revert "chore: generate SBOM for release artifacts (#3585)"

This reverts commit 1bad8a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants