Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Delete IL verification failure helpers in importer #108996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanasifkhalid
Copy link
Member

Part of #32648. Per this comment, I suspect this is the next (last?) step in removing IL verifier from the importer.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 17, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib -- are there any CI legs worth running for this?

@AndyAyersMS
Copy link
Member

I suspect this is the next (last?) step in removing IL verifier from the importer.

We might want to do some renaming, say verCurrentState -> stackState or something. And there are various comments that could be updated/removed.

cc @dotnet/jit-contrib -- are there any CI legs worth running for this?

I don't think so; no diffs should be sufficient.

Our SPMI collection set is a bit impoverished right now, so maybe wait until that's fixed and rerun?

@amanasifkhalid
Copy link
Member Author

Our SPMI collection set is a bit impoverished right now, so maybe wait until that's fixed and rerun?

Sure; I'll get the renaming out of the way in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants