Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compiler crash when UsageBasedMetadataGenerationOptions.CompleteTypesOnly is specified #106445

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Avoid compiler crash when UsageBasedMetadataGenerationOptions.CompleteTypesOnly is specified #106445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/TypeMetadataNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ public override IEnumerable<DependencyListEntry> GetStaticDependencies(NodeFacto
{
try
{
// Make sure we're not adding a method to the dependency graph that is going to
// cause trouble down the line. This entire type would not actually load on CoreCLR anyway.
LibraryRootProvider.CheckCanGenerateMethod(method);
// Spot check by parsing signature.
// Previously we had LibraryRootProvider.CheckCanGenerateMethod(method) here, but that one
// expects fully instantiated types and methods. We operate on definitions here.
// This is not as thorough as it could be. This option is unsupported anyway.
_ = method.Signature;
}
catch (TypeSystemException)
{
Expand Down