Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor MarkdigExtensionSetting deserialization logics #10311

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: Refactor MarkdigExtensionSetting deserialization logics #10311

merged 1 commit into from
Oct 22, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 21, 2024

This PR contains following changes

  • Simplify deserialization logics.
  • Remove IncludeFields option. (It seems not used by any available markdig options)
  • Add JsonCommentHandling.Skip (Previously it works because comment is dropped with text serialization)
  • Add simple test to verify behaviors of above changes.
    • Add markdownServiceProperties test case that contains comment.
    • Modify invalid test data (width/height should be string)

@filzrev filzrev force-pushed the chore-refactor-markdigsettings-serialization branch from c5a7791 to ae35be4 Compare October 21, 2024 12:56
@yufeih yufeih merged commit d12f688 into dotnet:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filzrev @yufeih