Clean up unsupported native AOT flags #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `llcOptimizationPreference` was renamed to `OptimizationPreference` and became supported in .NET 8 (or maybe .NET 7, it doesn't matter) * `IlcGenerateStackTraceData` is now `StackTraceSupport` and supported. (Also got renamed in .NET 8 or earlier.) I'm leaving the old names of properties for backcompat. We could also delete them. I don't know how much BDN cares about .NET versions that are out of support. IlcGenerateCompleteTypeMetadata is unsupported, we don't test it, it's a mode for troubleshooting trimming issues for people who ignore trimming warnings. I don't think BDN should be setting this. You'll only find bugs (dotnet/runtime#106439). So deleting that. Not deleting the API because it looks to be a public API.
am11
reviewed
Aug 15, 2024
|
@MichalStrehovsky, there is another warning due to line 167:
This patch should fix it: - : "<TrimMode>link</TrimMode><TrimmerDefaultAction>link</TrimmerDefaultAction>";
+ : @"<TrimMode>link</TrimMode>
+ <TrimmerDefaultAction Condition=""$([MSBuild]::VersionLessThan('$(NETCoreSdkVersion)', '7.0'))"">link</TrimmerDefaultAction>"; |
We'd also need to condition TrimMode - valid values of TrimMode after .NET 7 are These are however all orthogonal to what this PR is doing. |
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
adamsitnik
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llcOptimizationPreferencewas renamed toOptimizationPreferenceand became supported in .NET 8 (or maybe .NET 7, it doesn't matter)IlcGenerateStackTraceDatais nowStackTraceSupportand supported. (Also got renamed in .NET 8 or maybe in 7 already.)I'm leaving the old names of properties for backcompat. We could also delete them. I don't know how much BDN cares about .NET versions that are out of support.
The last one,
IlcGenerateCompleteTypeMetadatais unsupported, we don't test it, it's a mode for troubleshooting trimming issues for people who ignore trimming warnings. I don't think BDN should be setting this. You'll only find bugs (dotnet/runtime#106439). So deleting that. Not deleting the API because it looks to be a public API.