chore(edit-content): improve load time in edit content form #30392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nicobytes
changed the title
oidacra
approved these changes
Oct 18, 2024
zJaaal
approved these changes
Oct 18, 2024
hmoreras
approved these changes
Oct 18, 2024
valentinogiardino
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
#30389
Summary
This pull request includes significant changes to the
dot-edit-content-fieldcomponent in thecore-weblibrary. The main updates involve deferring the rendering of various field components and removing the now unnecessaryDotEditContentFieldsModule.Rendering Optimization:
@defer (on immediate)directive to defer the rendering of multiple field components indot-edit-content-field.component.htmlto improve performance. (core-web/libs/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html)Module Refactoring:
DotEditContentFieldsModuleand updated the imports to include individual field components directly indot-edit-content-field.component.ts. (core-web/libs/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.ts) [1] [2]DotEditContentFieldsModulefile. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-fields.module.ts)Checklist
Screenshots
With all fields, each field is loaded only when necessary.
When the user selects a few fields, only those fields are loaded
This PR fixes: #30389