fix(pp) fixing edge push cases where content and folders from non-pushed hosts gets dragged along by dependency, and containers in a drafted state fail to publish #30380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed hosts gets dragged along by dependency, and containers in a drafted state fail to publish ref: #30370
3 tasks
jcastro-dotcms
approved these changes
Oct 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #30370
This PR updates the
FolderHandlerand theContentletHandlerto ignore folders and contents that live on a host that does not exist in the target system.It also insures that the working inode of any pushed container is the one that is just saved by the
ContainerHandlerwhen it is creating a container for the first time, which fixes a case where there are different live/working versions of a container on the sender and the sender only sends the live version.Finally, it fixes the crappy Bundle Upload screen so now the dialog does not stay open the whole time while the bundle is being uploaded AND ingested.