Dhis2 18142/category option group forms #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
reviewed
Oct 21, 2024
Birkbjo
reviewed
Oct 21, 2024
Birkbjo
reviewed
Oct 21, 2024
Birkbjo
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Looks good, just some minor remnants from copy-pasting (which is perfectly valid here btw!).
Can you also add an entry for categoryOptionGroup to sectionListViewsConfig?
I think it makes sense to have much of the same config as category, but without categoryCombo as a filter.
After #423 is merged, we could also add categoryOption as a filter.
…o DHIS2-18142/category-option-group-forms
Birkbjo
reviewed
Oct 22, 2024
src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx
Outdated
Show resolved
Hide resolved
Birkbjo
reviewed
Oct 22, 2024
src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx
Outdated
Show resolved
Hide resolved
Birkbjo
reviewed
Oct 22, 2024
…o DHIS2-18142/category-option-group-forms
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-18142
Description
Implement Category option group management flow which includes the list page, the create page as well as the edit page.
Checklist