Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove select all checkbox from org list #414

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

flaminic
Copy link
Contributor

@flaminic flaminic commented Sep 10, 2024

Implements DHIS2-18032

Removing the select all checkbox in the header for othUnit list
Screenshot 2024-09-10 at 10 35 25

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit e4f5488
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/66e1cbb8302ad30008fb2550
😎 Deploy Preview https://deploy-preview-414--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flaminic flaminic force-pushed the DHIS2-18032/remove-select-all-from-org-unit-list branch 3 times, most recently from 35f7395 to 32b60cb Compare September 11, 2024 16:48
this is because with multi pages we will never be able to select all the childs
@flaminic flaminic force-pushed the DHIS2-18032/remove-select-all-from-org-unit-list branch from 32b60cb to e4f5488 Compare September 11, 2024 16:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (a8dfc9d) to head (e4f5488).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   62.05%   62.09%   +0.04%     
==========================================
  Files         192      192              
  Lines        2991     2992       +1     
  Branches      669      671       +2     
==========================================
+ Hits         1856     1858       +2     
+ Misses       1132     1131       -1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flaminic flaminic merged commit 84cfd3e into master Sep 12, 2024
8 of 10 checks passed
@flaminic flaminic deleted the DHIS2-18032/remove-select-all-from-org-unit-list branch September 12, 2024 12:50
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants