feat: prefix time dimension ids with program id when tracked entity output type #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-480--dhis2-line-listing.netlify.app |
7 failed tests on run #2410 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| integer > integer with negative value |
Test Replay
Screenshots
Video
|
|
| integer > integer with positive value |
Test Replay
Screenshots
Video
|
|
| integer > integer with 0 |
Test Replay
Screenshots
Video
|
|
repeatedEvents.cy.js • 2 failed tests • e2e-chrome-parallel-dev
| Test | Artifacts | |
|---|---|---|
| repeated events > can use repetition for enrollments |
Test Replay
Screenshots
Video
|
|
| repeated events > repetition out of bounds returns as empty value |
Test Replay
Screenshots
Video
|
|
programStatus.cy.js • 1 failed test • e2e-chrome-parallel-dev
| Test | Artifacts | |
|---|---|---|
| program status (TE) > can be filtered by status COMPLETED |
Test Replay
Screenshots
Video
|
|
createTrackedEntity.cy.js • 1 failed test • e2e-chrome-parallel-dev
| Test | Artifacts | |
|---|---|---|
| tracked entity > creates a line list with dimensions |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #480 ↗︎
…h-programid-prefix
…h-programid-prefix
…m:dhis2/line-listing-app into feat/timedimensions-with-programid-prefix
…h-programid-prefix
…h-programid-prefix
…h-programid-prefix
martinkrulltott
approved these changes
Jan 23, 2024
jenniferarnesen
merged commit e0398d0
into
feat/tracked-entity-input
12 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://dhis2.atlassian.net/browse/DHIS2-16023
Description
Time dimensions need to be prefixed with the programId when using TE output type. The following works:
The failing cypress tests are the same as the target branch