-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show legend when table is very wide (DHIS2-16286) #468
Merged
HendrikThePendric
merged 7 commits into
feat/DHIS2-15358-legend-key-toggle
from
DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide
Jan 11, 2024
Merged
fix: show legend when table is very wide (DHIS2-16286) #468
HendrikThePendric
merged 7 commits into
feat/DHIS2-15358-legend-key-toggle
from
DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-468--dhis2-line-listing.netlify.app |
HendrikThePendric
changed the title
DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide
fix: show legend when table is very wide
Dec 11, 2023
HendrikThePendric
changed the title
fix: show legend when table is very wide
fix: show legend when table is very wide (DHIS2-16286)
Dec 11, 2023
Passing run #2223 ↗︎
Details:
Review all test suite changes for PR #468 ↗︎ |
martinkrulltott
approved these changes
Dec 11, 2023
3 tasks
* chore: use alpha version of analytics * chore: use analytics@26.2.0
BRANCH_NAME CI_BUILD_ID PR_TITLE Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
…en-line-list-is-wide
martinkrulltott
changed the base branch from
master
to
fix/legend-key-issues
December 20, 2023 09:49
martinkrulltott
changed the base branch from
fix/legend-key-issues
to
feat/DHIS2-15358-legend-key-toggle
December 20, 2023 09:51
…gend-key-outside-viewport-when-line-list-is-wide
HendrikThePendric
merged commit Jan 11, 2024
7c3d65d
into
feat/DHIS2-15358-legend-key-toggle
28 checks passed
HendrikThePendric
deleted the
DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide
branch
January 11, 2024 12:19
🎉 This PR is included in version 100.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@@ -42,6 +43,7 @@ | |||
.fetchContainer { | |||
display: flex; | |||
align-self: flex-start; | |||
gap: var(--spacers-dp4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16286
Key features
Screenshots