Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show legend when table is very wide (DHIS2-16286) #468

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Dec 11, 2023

Implements DHIS2-16286


Key features

  1. Show legend key even when table is very wide

Screenshots

Screenshot 2023-12-11 at 15 26 20

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 11, 2023

🚀 Deployed on https://pr-468--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2023 14:29 Inactive
@HendrikThePendric HendrikThePendric changed the title DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide fix: show legend when table is very wide Dec 11, 2023
@HendrikThePendric HendrikThePendric changed the title fix: show legend when table is very wide fix: show legend when table is very wide (DHIS2-16286) Dec 11, 2023
Copy link

cypress bot commented Dec 11, 2023

Passing run #2223 ↗︎

0 520 0 0 Flakiness 0

Details:

Merge 8a5de8a into d5d755a...
Project: line-listing-app Commit: cc0a5d2ef4 ℹ️
Status: Passed Duration: 13:52 💡
Started: Dec 20, 2023 10:25 AM Ended: Dec 20, 2023 10:38 AM

Review all test suite changes for PR #468 ↗︎

edoardo and others added 3 commits December 14, 2023 16:11
* chore: use alpha version of analytics

* chore: use analytics@26.2.0
BRANCH_NAME CI_BUILD_ID PR_TITLE

Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
@dhis2-bot dhis2-bot temporarily deployed to netlify December 20, 2023 09:18 Inactive
@martinkrulltott martinkrulltott changed the base branch from master to fix/legend-key-issues December 20, 2023 09:49
@martinkrulltott martinkrulltott changed the base branch from fix/legend-key-issues to feat/DHIS2-15358-legend-key-toggle December 20, 2023 09:51
…gend-key-outside-viewport-when-line-list-is-wide
@dhis2-bot dhis2-bot temporarily deployed to netlify December 20, 2023 09:54 Inactive
@HendrikThePendric HendrikThePendric merged commit 7c3d65d into feat/DHIS2-15358-legend-key-toggle Jan 11, 2024
28 checks passed
@HendrikThePendric HendrikThePendric deleted the DHIS2-16286-legend-key-outside-viewport-when-line-list-is-wide branch January 11, 2024 12:19
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -42,6 +43,7 @@
.fetchContainer {
display: flex;
align-self: flex-start;
gap: var(--spacers-dp4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants