-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skip rounding option (DHIS2-15629) #424
Conversation
🚀 Deployed on https://pr-424--dhis2-line-listing.netlify.app |
Passing run #2431 ↗︎
Details:
Review all test suite changes for PR #424 ↗︎ |
3467ff5
to
c71f03b
Compare
11c5d4e
to
be58e83
Compare
showHierarchy option should translate into a custom header, instead of a analytics request parameter. Other options like skipRounding instead should be treated like a normal parameter passed to the analytics request.
For now it toggles on 2.41, but it can be adjusted if the backend fix is going out on a patch release before 41.
Co-authored-by: Martin <martin@moid.se>
This can change over time and would need to be replaced every time.
be58e83
to
b405a12
Compare
# [100.15.0](v100.14.0...v100.15.0) (2024-01-30) ### Features * add skip rounding option (DHIS2-15629) ([#424](#424)) ([4ddbed9](4ddbed9))
🎉 This PR is included in version 100.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@@ -18,6 +18,11 @@ export const clickMenubarOptionsButton = () => | |||
.contains('Options') | |||
.click() | |||
|
|||
export const openDataOptionsModal = () => { | |||
clickMenubarOptionsButton() | |||
return cy.getBySel('options-menu-list').contains('Data').click() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should use return here. Since Cypress doesn't actually return anything. I know this is probably just a copy paste from the code below (written by @HendrikThePendric originally) but still it should be avoided.
Implements DHIS2-15629
Key features
Description
The analytics request can already handle the rounding of numeric values via
skipRounding
parameter.LL didn't have the option exposed in the Options modal which allows to control the parameter in the analytics request.
TODO
Screenshots
Option in the Options modal:
Example with the rounding (default):
Example without the rounding: