feat: add skip rounding option (DHIS2-15629) #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-424--dhis2-line-listing.netlify.app |
Passing run #2431 ↗︎
Details:
Review all test suite changes for PR #424 ↗︎ |
|||||||||||||||
martinkrulltott
approved these changes
Aug 9, 2023
edoardo
force-pushed
the
feat/add-skip-rounding-option
branch
from
3467ff5
to
c71f03b
Compare
janhenrikoverland
changed the title
martinkrulltott
added
the
Awaiting Core Release
edoardo
force-pushed
the
feat/add-skip-rounding-option
branch
from
11c5d4e
to
be58e83
Compare
showHierarchy option should translate into a custom header, instead of a analytics request parameter. Other options like skipRounding instead should be treated like a normal parameter passed to the analytics request.
For now it toggles on 2.41, but it can be adjusted if the backend fix is going out on a patch release before 41.
Co-authored-by: Martin <martin@moid.se>
This can change over time and would need to be replaced every time.
edoardo
force-pushed
the
feat/add-skip-rounding-option
branch
from
be58e83
to
b405a12
Compare
dhis2-bot
added a commit
that referenced
this pull request
Jan 30, 2024
# [100.15.0](v100.14.0...v100.15.0) (2024-01-30) ### Features * add skip rounding option (DHIS2-15629) ([#424](#424)) ([4ddbed9](4ddbed9))
|
🎉 This PR is included in version 100.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -18,6 +18,11 @@ export const clickMenubarOptionsButton = () => | |||
| .contains('Options') | |||
| .click() | |||
|
|
|||
| export const openDataOptionsModal = () => { | |||
| clickMenubarOptionsButton() | |||
| return cy.getBySel('options-menu-list').contains('Data').click() | |||
There was a problem hiding this comment.
I don't think we should use return here. Since Cypress doesn't actually return anything. I know this is probably just a copy paste from the code below (written by @HendrikThePendric originally) but still it should be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15629
Key features
Description
The analytics request can already handle the rounding of numeric values via
skipRoundingparameter.LL didn't have the option exposed in the Options modal which allows to control the parameter in the analytics request.
TODO
Screenshots
Option in the Options modal:
Example with the rounding (default):
Example without the rounding:
