-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : 예약 알림 기능 추가 #93
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fe7fc78
feat : owner 엔티티에 알림 활성화 여부 필드 추가
dlswns2480 a98ec84
feat : 알림보내는 이벤트 리스너에 조건 추가
dlswns2480 60b6bdb
feat : 예약 등록 시 알림 전송 로직 추가
dlswns2480 67ccba1
feat : shop을 통해 점주 조회 쿼리 추가 및 테스트
dlswns2480 edf5848
feat : NotificationContent Function활용해 알림 메세지 리턴하는 것으로 수정 (시간 받아서 해당 …
dlswns2480 32da933
feat : 알림 내용 String 인자 받는 것으로 변경
dlswns2480 07b8720
feat : 알림 보내는 로직 추가(예약 등록, 취소)
dlswns2480 4f64b6a
style : 코드 포맷
dlswns2480 6ced9aa
fix : 테스트 오류 수정
dlswns2480 2c3982e
feat : 예약 취소 api에 멤버 추가
dlswns2480 161e00e
feat : 알림 보내는 로직 메소드로 추출
dlswns2480 8efb45f
feat : 알림 로직 수정에 따른 테스트
dlswns2480 7a0abb1
style : 코드 포맷팅
dlswns2480 ae82272
enum 표현식 메소드명 수정
dlswns2480 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 10 additions & 8 deletions
18
src/main/java/com/prgrms/catchtable/common/notification/NotificationContent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,22 @@ | ||
package com.prgrms.catchtable.common.notification; | ||
|
||
import java.util.function.Function; | ||
import lombok.Getter; | ||
import lombok.RequiredArgsConstructor; | ||
|
||
@RequiredArgsConstructor | ||
@Getter | ||
public enum NotificationContent { | ||
RESERVATION_COMPLETED("예약이 완료되었습니다"), | ||
RESERVATION_ONE_HOUR_LEFT("예약 시간 1시간 전입니다."), | ||
RESERVATION_TIME_TO_ENTER("예약시간이 되었습니다"), | ||
WAITING_REGISTER_COMPLETED("웨이팅 등록이 완료되었습니다"), | ||
WAITING_RANK_THIRD("웨이팅 순서가 3번째가 되었습니다"), | ||
WAITING_TIME_TO_ENTER("웨이팅이 끝났습니다. 입장 부탁드립니다."), | ||
WAITING_CANCELLED_AUTOMATICALLY("웨이팅이 자동으로 취소되었습니다."); | ||
RESERVATION_COMPLETED(time -> time.concat(" 시간의 예약이 완료 되었습니다.")), | ||
RESERVATION_CANCELLED(time -> time.concat(" 시간의 예약이 취소 되었습니다")), | ||
RESERVATION_ONE_HOUR_LEFT(time -> time.concat(" 시간 예약까지 한시간 남았습니다")), | ||
RESERVATION_TIME_OUT(time -> "예약 시간이 되었습니다. 입장해주세요."); | ||
|
||
private final String message; | ||
|
||
private final Function<String, String> expression; | ||
|
||
public String getMessage(String time) { | ||
return expression.apply(time); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 메서드명을 getMessage()이런 식으로 변경해도 괜찮을 것 같다는 생각이 듭니다..! |
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
src/main/java/com/prgrms/catchtable/notification/dto/request/SendMessageToMemberRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
package com.prgrms.catchtable.notification.dto.request; | ||
|
||
import com.prgrms.catchtable.common.notification.NotificationContent; | ||
import com.prgrms.catchtable.member.domain.Member; | ||
import lombok.Builder; | ||
|
||
@Builder | ||
public record SendMessageToMemberRequest(Member member, | ||
NotificationContent content) { | ||
String content) { | ||
|
||
} |
3 changes: 1 addition & 2 deletions
3
src/main/java/com/prgrms/catchtable/notification/dto/request/SendMessageToOwnerRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
package com.prgrms.catchtable.notification.dto.request; | ||
|
||
import com.prgrms.catchtable.common.notification.NotificationContent; | ||
import com.prgrms.catchtable.owner.domain.Owner; | ||
import lombok.Builder; | ||
|
||
@Builder | ||
public record SendMessageToOwnerRequest(Owner owner, | ||
NotificationContent content) { | ||
String content) { | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/test/java/com/prgrms/catchtable/owner/repository/OwnerRepositoryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package com.prgrms.catchtable.owner.repository; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase.Replace.NONE; | ||
|
||
import com.prgrms.catchtable.owner.domain.Owner; | ||
import com.prgrms.catchtable.owner.fixture.OwnerFixture; | ||
import com.prgrms.catchtable.shop.domain.Shop; | ||
import com.prgrms.catchtable.shop.fixture.ShopFixture; | ||
import com.prgrms.catchtable.shop.repository.ShopRepository; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase; | ||
import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; | ||
|
||
@DataJpaTest | ||
@AutoConfigureTestDatabase(replace = NONE) | ||
class OwnerRepositoryTest { | ||
|
||
@Autowired | ||
private OwnerRepository ownerRepository; | ||
@Autowired | ||
private ShopRepository shopRepository; | ||
|
||
@Test | ||
@DisplayName("매장을 통해 점주를 찾을 수 있다") | ||
void findByShop() { | ||
Shop shop = ShopFixture.shop(); | ||
Shop savedShop = shopRepository.save(shop); | ||
|
||
Owner owner = OwnerFixture.getOwner("injun", "injun2480"); | ||
owner.insertShop(savedShop); | ||
Owner savedOwner = ownerRepository.save(owner); | ||
|
||
Owner findOwner = ownerRepository.findOwnerByShop(savedShop).orElseThrow(); | ||
|
||
assertThat(findOwner).isEqualTo(savedOwner); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍