feature : owner 웨이팅 조회 API 구현 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kkangh00n
approved these changes
Jan 8, 2024
| Owner owner = ownerRepository.findById(ownerId) | ||
| .orElseThrow(() -> new BadRequestCustomException(NOT_EXIST_OWNER)); | ||
| List<Long> waitingIds = waitingLineRepository.getShopWaitingIdsInOrder( | ||
| owner.getShop().getId()); |
There was a problem hiding this comment.
owner.getShop().getId() 부분 말씀하시는건가요? 현재 임시로만 ownerId를 받는거라서 fetch join은 구현하지 않았습니다!
dlswns2480
approved these changes
Jan 8, 2024
...in/java/com/prgrms/catchtable/waiting/repository/waitingline/RedisWaitingLineRepository.java
Outdated
Show resolved
Hide resolved
Comment on lines
51
to
54
| List<Long> longList = new ArrayList<>(stringList.stream() | ||
| .map(Long::parseLong) | ||
| .toList()); | ||
| Collections.reverse(longList); |
There was a problem hiding this comment.
pr에 rank순으로 정렬해서 가져온다했는데 그게 이 부분인가요?? 정렬은 안 보이고 reverse()만 보여서요.. 몰라서 질문드립니다!
There was a problem hiding this comment.
넵! 리스트에 데이터 삽입 시 왼쪽으로 계속 삽입되기 때문에 rank가 큰 순으로 waitingId가 정렬되어 있습니다.
이를 reverse()로 rank가 작은 순으로 정렬해 반환하는 로직입니다. ex: [3L, 2L, 1L] -> [1L, 2L, 3L]
src/test/java/com/prgrms/catchtable/waiting/fixture/WaitingFixture.java
Outdated
Show resolved
Hide resolved
...ava/com/prgrms/catchtable/waiting/repository/waitingline/BasicWaitingLineRepositoryTest.java
Outdated
Show resolved
Hide resolved
...ava/com/prgrms/catchtable/waiting/repository/waitingline/BasicWaitingLineRepositoryTest.java
Show resolved
Hide resolved
src/test/java/com/prgrms/catchtable/waiting/service/OwnerWaitingServiceTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 상세 내용
📝 작업 요약
☑️ 중점적으로 리뷰 할 부분