feat : OAuth2.0 카카오 로그인 & JWT 인증 구현 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlswns2480
reviewed
Dec 27, 2023
Comment on lines
+58
to
+66
| public Member(String name, String email, String phoneNumber, Gender gender, | ||
| LocalDate dateBirth) { | ||
| this.name = name; | ||
| this.email = email; | ||
| this.phoneNumber = phoneNumber; | ||
| this.gender = gender; | ||
| this.dateBirth = dateBirth; | ||
| this.notification_activated = notification_activated; | ||
| this.notification_activated = true; | ||
| this.role = Role.MEMBER; |
There was a problem hiding this comment.
저희 회원 생성시에 알림 활성화는 항상 true로 생성되나요??
There was a problem hiding this comment.
기존 회원가입 시, 알림 활성화가 될거라 혼자 판단했는데 한번 스크럼 때 말해보는게 좋겠군요..!!
| SessionCreationPolicy.STATELESS)) | ||
| .formLogin(AbstractHttpConfigurer::disable) | ||
| .authorizeHttpRequests(authorization -> authorization | ||
| .requestMatchers(new AntPathRequestMatcher("/**")).permitAll() |
There was a problem hiding this comment.
이 부분 나중에 url 여러개 넣을 때 위에 문자열 배열로 빼서 거기에다 url 정의해놓아도 좋을 것 같습니다!
src/main/java/com/prgrms/catchtable/security/dto/OAuthAttribute.java
Outdated
Show resolved
Hide resolved
Comment on lines
+52
to
+53
| } else { | ||
| throw new UsernameNotFoundException("Please Login again"); |
There was a problem hiding this comment.
Security 필터내에서 예외를 던지면 이 예외가 인식이 되나요??
There was a problem hiding this comment.
예외 필터를 따로 구현 후, 앞단에 두어 처리해야합니다..!! 추가 후 리뷰요청 날리겠습니다~!
|
리뷰 달았습니다! 로그인 실패 처리랑 테스트 코드만 추가되면 될 것 같습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #8
⛏ 작업 상세 내용
📝 작업 요약
☑️ 중점적으로 리뷰 할 부분