Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atmospheric transmission correction to daisy command #182

Closed
wants to merge 1 commit into from
Closed

Add atmospheric transmission correction to daisy command #182

wants to merge 1 commit into from

Conversation

hapipapijuris
Copy link
Contributor

@hapipapijuris hapipapijuris commented Jul 24, 2024 •
edited by astropenguin
Loading

Closes #179.

@hapipapijuris hapipapijuris self-assigned this Jul 24, 2024
@astropenguin astropenguin changed the title daisy atm-correction Add atmospheric transmission correction to daisy command Jul 24, 2024
@astropenguin astropenguin added the feature New feature or request label Jul 24, 2024
@astropenguin astropenguin added this to the v2024.8 milestone Jul 24, 2024
astropenguin
astropenguin requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you created the branch not from main but from issue153, and the branch name should be not issue180 but issue179. Could you redo the work?

@astropenguin astropenguin mentioned this pull request Jul 29, 2024
Merged
@astropenguin
Copy link
Member

Closed by #188.

@astropenguin astropenguin deleted the issue180 branch August 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astropenguin astropenguin astropenguin requested changes

Assignees

@hapipapijuris hapipapijuris

Labels
feature New feature or request
Projects
DESHIMA 2.1
Status: Done
Milestone
v2024.8
Development

Successfully merging this pull request may close these issues.

Add atmospheric transmission correction to daisy command
2 participants
@hapipapijuris @astropenguin