-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed time complexcity #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting for better readability
Update gBot.js
Update gBot.js
hover highlighting for the row
Origin/kgashok patch 4
dishonesty Account added to the condition to skip the calculation
Update getBrownies.test.js
Update README.md
…rdushy-master Conflicts: .gitignore Readme.md index.html style.css
|
Dushyanth,
The JS FCC CamperBot app is really fast now!
Congratulations on the improved performance.
kgisl/FCC-Status deploys automatically to Heroku at
https://kgfcc.herokuapp.com/
% ashok
…On 27 December 2016 at 00:15, ddr dushy ***@***.***> wrote:
code redesigned for making async request ajax calls.
------------------------------
You can view, comment on, or merge this pull request online at:
#16
Commit Summary
- Formatted data.json into multiple lines for better readability
- Renamed the README file; add some more comments
- Refactored code from index.html into .js and .css files
- Added the the meta tags DOCTYPE and character encoding, Issue #10
- Update gBot.js
- Merge pull request #1 from kgisl/kgashok-patch-1
- Fix indendation using Sublime Text 3
- Added PHP file for deploying to Heroku
- Added "unresponsive error" screenshot, Issue #2
- added app and static files
- empty
- Added app.json and static.json to deploy on Heroku, Issue #6
- minor edits
- minor change in CSS
- Merge branch 'master' of https://github.com/kgisl/FCC-Status
- Formatted for better readability
- Added back the PHP file as a legacy asset
- Renamed image file name to avoid pull problems as in
#13
<#13>
- Added Grunt and Travis for JS Linting
- Added Travis status image
- Modifications to pass lint errors
- the JS file now lives in ./src/js
- Fixed jshint issues except in Gruntfile.js
- Changed indentation to 2; Resolved #7 and ddrdushy/FCC-Status/#15
- Update gBot.js
- Merge pull request #8 from kgisl/kgashok-patch-1
- Update gBot.js
- Update style.css
- moved line into the right place
- Merge pull request #13 from kgisl/origin/kgashok-patch-4
- Use KG colours for highlighting!
- Added qunit testing
- modified Gruntfile.js to incorporate qunit tests
- Gruntfile.js also lint ready; Resolved #14
- Introduced opacity for the highlighting
- Update style.css
- Merge pull request #17 from kgisl/kgashok-patch-1
- Update style.css
- Merge pull request #18 from kgisl/kgashok-patch-1
- Added automated testing using grunt watch
- Change made to inform CI and CD and Auto-testing; Resolves #19
- Revert back to not include watch; to fix Travis fail
- Use the right version for watch
- changed version numbers to fix Travis fail
- revert back to earlier
- avoid linting gruntfile for now
- included gruntfile back
- removed watch
- added watch back
- added phantom back
- removed phantomJS ref
- Qunit coverage also possible; sample Bot code tested; resolved #20
- Used jsdevenv Gruntfile.js and node_modules dir; Resolved #20
- Removed all lint errors; reverted back to tab space 4
- gBot.js location altered in index.html file
- Coverage tests were failing; commented out the require line
- lint-free'ing getBrownies
- added jquery to get tests to pass; coverage still failing
- Gruntfile fix to make Travis build pass
- minor edits
- Changed node version; made async test
- Removed test to make Travis CI pass
- Included coverage
- included test back to check on Travis CI
- added test back in
- moving back to previous state
- Lint error fixed
- removed test to make Travis CI pass
- Added back Ajax test to see if it fails Travis CI
- fixed Lint error
- changed from asynTest to Test
- Update gBot.js
- Merge pull request #24 from kgisl/kgashok-patch-1
- Update index.html
- Add files via upload
- Update gBot.js
- Merge pull request #25 from kgisl/kgashok-patch-1
- Update gBot.js
- Merge pull request #26 from kgisl/kgashok-patch-1
- Update Gruntfile.js
- Merge pull request #28 from kgisl/kgashok-patch-1
- Update Gruntfile.js
- Update Gruntfile.js
- Account skiped
- Update gBot.js
- Update getBrownies.test.js
- fixed test case
- Merge branch 'master' of https://github.com/kgisl/FCC-Status
- Merge pull request #30 from kgisl/kgashok-patch-2
- Update README.md
- Merge pull request #31 from kgisl/kgashok-patch-1
- added shrinkwrap
- Merge branch 'master' of https://github.com/kgisl/FCC-Status
- Trying coverage on snap-ci
- switched back to 'test'
- trying coverage on snap-ci
- removing node_modules folder
- replaced coverage with test
- Added node_modules to .gitignore
- Removed coverage
- moved shrinkwrap out to backup
- added coverage
- added test back in
File Changes
- *M* .gitignore
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-0> (3)
- *A* .travis.yml
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-1> (3)
- *A* Gruntfile.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-2> (132)
- *A* Gruntfile.js.bak
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-3> (91)
- *A* README.md
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-4> (22)
- *D* Readme.md
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-5> (4)
- *A* app.json
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-6> (9)
- *M* data.json
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-7> (1904)
- *A* img/UnResponsiveErrorMay282016.png
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-8> (0)
- *A* img/loading.gif
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-9> (0)
- *M* index.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-10> (201)
- *A* index.php.bak
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-11> (1)
- *A* install_phantomjs.sh
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-12> (20)
- *A* npm-shrinkwrap.json.bak
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-13> (388)
- *A* output/coverage/in/src/js/gBot.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-14> (258)
- *A* output/coverage/in/src/js/jscoverage-highlight.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-15> (38)
- *A* output/coverage/in/src/js/jscoverage-ie.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-16> (108)
- *A* output/coverage/in/src/js/jscoverage-throbber.gif
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-17> (0)
- *A* output/coverage/in/src/js/jscoverage.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-18> (355)
- *A* output/coverage/in/src/js/jscoverage.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-19> (164)
- *A* output/coverage/in/src/js/jscoverage.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-20> (1176)
- *A* output/coverage/in/src/js/main.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-21> (53)
- *A* output/coverage/in/src/js/requireConfig.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-22> (46)
- *A* output/coverage/in/src/js/util/getBrownies.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-23> (90)
- *A* output/coverage/in/src/js/util/getBrownies.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-24> (76)
- *A* output/coverage/in/src/js/util/passwordEvaluator.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-25> (131)
- *A* output/coverage/in/src/js/util/passwordEvaluator.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-26> (99)
- *A* output/coverage/in/src/js/util/random.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-27> (60)
- *A* output/coverage/in/src/js/util/random.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-28> (74)
- *A* output/coverage/in/src/lib/jquery.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-29> (9440)
- *A* output/coverage/in/src/lib/require.min.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-30> (35)
- *A* output/coverage/in/src/test/index.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-31> (28)
- *A* output/coverage/in/src/test/lib/qunit.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-32> (231)
- *A* output/coverage/in/src/test/lib/qunit.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-33> (1932)
- *A* output/coverage/in/src/test/lib/sinon.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-34> (4081)
- *A* output/coverage/out/coverage.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-35> (1)
- *A* output/coverage/out/gBot.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-36> (202)
- *A* output/coverage/out/main.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-37> (43)
- *A* output/coverage/out/out.temp
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-38> (68)
- *A* output/coverage/out/requireConfig.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-39> (42)
- *A* output/coverage/out/util/getBrownies.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-40> (85)
- *A* output/coverage/out/util/getBrownies.test.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-41> (54)
- *A* output/coverage/out/util/passwordEvaluator.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-42> (70)
- *A* output/coverage/out/util/passwordEvaluator.test.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-43> (62)
- *A* output/coverage/out/util/random.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-44> (40)
- *A* output/coverage/out/util/random.test.js.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-45> (53)
- *A* output/testresults/TEST-index.xml
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-46> (37)
- *A* package.json
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-47> (23)
- *A* package.json.bak
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-48> (18)
- *A* src/index.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-49> (14)
- *A* src/js/gBot.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-50> (168)
- *A* src/js/main.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-51> (9)
- *A* src/js/requireConfig.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-52> (8)
- *A* src/js/util/getBrownies.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-53> (52)
- *A* src/js/util/getBrownies.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-54> (20)
- *A* src/js/util/passwordEvaluator.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-55> (36)
- *A* src/js/util/passwordEvaluator.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-56> (28)
- *A* src/js/util/random.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-57> (7)
- *A* src/js/util/random.test.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-58> (19)
- *A* src/lib/jquery.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-59> (9440)
- *A* src/lib/require.min.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-60> (35)
- *A* src/test/index.html
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-61> (28)
- *A* src/test/lib/qunit.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-62> (231)
- *A* src/test/lib/qunit.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-63> (1932)
- *A* src/test/lib/sinon.js
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-64> (4081)
- *A* static.json
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-65> (3)
- *A* style.css
<https://github.com/ddrdushy/FCC-Status/pull/16/files#diff-66> (14)
Patch Links:
- https://github.com/ddrdushy/FCC-Status/pull/16.patch
- https://github.com/ddrdushy/FCC-Status/pull/16.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACSbIqGC2xhIK33vKA_Z_zu-BDYS-_rdks5rMAs4gaJpZM4LV4Ta>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code redesigned for making async request ajax calls.