Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting dbt_valid_to snapshot column to new setting dbt_valid_to_current #1113

Merged
merged 13 commits into from
Oct 15, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 27, 2024

resolves #1112

Problem

Support work being done in dbt-core and dbt-adapters to enable setting the value of a current row in the dbt_valid_to column.

Support dbt-core https://github.com/dbt-core/issue/10187, dbt-adapters dbt-labs/dbt-adapters#321.

Solution

Use the "dbt_valid_to_current" config.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner September 27, 2024 19:06
@cla-bot cla-bot bot added the cla:yes label Sep 27, 2024
@gshank gshank enabled auto-merge (squash) October 15, 2024 21:24
@gshank gshank merged commit 805a08e into main Oct 15, 2024
17 of 18 checks passed
@gshank gshank deleted the snapshot_dbt_valid_to_current branch October 15, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In snapshots, enable setting current value of dbt_valid_to
2 participants