Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove npm update step to verify signatures #503

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Apr 9, 2024

Issue or need

There's no longer need to update npm to audit signatures properly

Given in latest release, npm bundled version 10.5.0 is already capable of auditing.

Relates to npm/cli#7279

Proposed changes

Remove npm update step in release process

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) April 9, 2024 23:05
@davidlj95 davidlj95 merged commit d5e473c into main Apr 9, 2024
13 checks passed
@davidlj95 davidlj95 deleted the stacked/ci-remove-npm-update-step-to-verify-signatures branch April 9, 2024 23:06
Copy link

github-actions bot commented Apr 9, 2024

📦 Bundle size (Angular v15)

Git ref: aaee082ea1324b1101d3e2a0bf494870cd4c7df9

Module file Size Base size Difference
ngx-meta-core.mjs 3507 bytes (3.5KiB) Not available Not available
ngx-meta-json-ld.mjs 392 bytes (392B) Not available Not available
ngx-meta-open-graph.mjs 1238 bytes (1.3KiB) Not available Not available
ngx-meta-routing.mjs 1015 bytes (1015B) Not available Not available
ngx-meta-standard.mjs 885 bytes (885B) Not available Not available
ngx-meta-twitter-card.mjs 659 bytes (659B) Not available Not available
Total 7696 bytes (7.6KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

github-actions bot commented Apr 9, 2024

📦 Bundle size (Angular v16)

Git ref: aaee082ea1324b1101d3e2a0bf494870cd4c7df9

Module file Size Base size Difference
ngx-meta-core.mjs 3507 bytes (3.5KiB) Not available Not available
ngx-meta-json-ld.mjs 392 bytes (392B) Not available Not available
ngx-meta-open-graph.mjs 1238 bytes (1.3KiB) Not available Not available
ngx-meta-routing.mjs 1015 bytes (1015B) Not available Not available
ngx-meta-standard.mjs 885 bytes (885B) Not available Not available
ngx-meta-twitter-card.mjs 659 bytes (659B) Not available Not available
Total 7696 bytes (7.6KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

github-actions bot commented Apr 9, 2024

📦 Bundle size (Angular v17)

Git ref: aaee082ea1324b1101d3e2a0bf494870cd4c7df9

Module file Size Base size Difference
ngx-meta-core.mjs 3094 bytes (3.1KiB) Not available Not available
ngx-meta-json-ld.mjs 226 bytes (226B) Not available Not available
ngx-meta-open-graph.mjs 899 bytes (899B) Not available Not available
ngx-meta-routing.mjs 839 bytes (839B) Not available Not available
ngx-meta-standard.mjs 768 bytes (768B) Not available Not available
ngx-meta-twitter-card.mjs 499 bytes (499B) Not available Not available
Total 6325 bytes (6.2KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

🎉 This PR is included in version 1.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant