Filter duplicate imports when completing

[WutingjiaX]

For the code snippet like:

from pydantic import Field, F

When the cursor is after the letter F，the completion includes item "Field", But this import actually already existed before

Pycharm also will not complete:

So I create a new pull request to filter duplicate imports.

However, there are still some details that have not been implemented(I don't think it's very important)，such as:

• filter duplicate imports in multiple imports statement
• import alias will also be filtered Generally, there is unlikely to be a situation where an alias is named exactly the same as a specific original name.

[WutingjiaX]

The CI is fail in specific operating system version， But it seems that it was not introduced by my changes

[davidhalter]

Thanks a lot! I'm happy to merge this once I have fixed the CI. I'm a bit confused how this started failing (because the last PR was fine). It's probably related to a Python 3.12 version upgrade. I will have to debug.

[davidhalter]

After a small fix the tests are fine again (https://github.com/davidhalter/jedi/actions/runs/11364219966). Would it be possible for you to rebase? I'd prefer to merge once the CI is green.

Thanks again, I think this is a useful addition and something that I found annoying as well!

[davidhalter]

Can you also add a test here for

s = 'from os import chdir as path, p'
assert 'path' in import_names(s)

I feel like this is still wrong.

[WutingjiaX]

Yes, it will be wrong. I mentioned it above:

import alias will also be filtered Generally, there is unlikely to be a situation where an alias is named exactly the same as a specific original name.

If you think it unacceptable，I can parse this syntax and remove it from the filter

[davidhalter]

Oh sorry, I didn't read that.

If you think it unacceptable，I can parse this syntax and remove it from the filter

I think it is acceptable, but it is the kind of thing I always fix before merging. So if you don't do it, I have to :)

I think it's also a very easy fix (probably one simple if).

[davidhalter]

Also know that this piece of software is used by millions of people, so issues like this one will appear sooner or later.

[WutingjiaX]

Done～

[davidhalter]

Thanks a lot for the quick fixes and in general for the PR, good stuff!