Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get email settings from env vars #94

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Get email settings from env vars #94

merged 1 commit into from
Oct 17, 2023

Conversation

xmedr
Copy link
Contributor

@xmedr xmedr commented Oct 12, 2023

Overview

I believe most email config vars weren't being set or imported into settings, preventing validation emails from being sent. This allows for the app to grab those variables.

If this is merged I'll add those vars to the staging/production apps.

Notes

I tried setting up a review app for this to make testing easier (hence all those deployments), and got a server error that made it seem like the version of postgres heroku was using wasn't compatible with the version of django that we're using. In trying to fix this I ended up in dependency hell, so for now local testing it is! 🎉

I still have those changes on a different branch in case we did want to set that up in the future.

Testing Instructions

  • In Bitwarden, search for "BGA Email Sending Credentials" and paste those values into .env.example (the default .env file the container uses, remember to undo after testing)
  • If you haven't built the app since 10/12/23, build it to get the recent mailchimp-auth changes
  • Bring up the app and trigger the modal
  • Use an email that hasn't been used for mailchimp yet in the signup form
  • Confirm that an email comes through to that address
  • Click the verification link
  • Confirm that the page gives you a success message, and that a confirmation email comes through

@xmedr xmedr temporarily deployed to ia-pensions-fix-email-s-5nbbyz October 12, 2023 19:22 Inactive
@fgregg fgregg temporarily deployed to ia-pensions-fix-email-s-jawtlu October 12, 2023 19:31 Inactive
@fgregg fgregg temporarily deployed to ia-pensions-fix-email-s-am3ywi October 12, 2023 19:36 Inactive
@xmedr xmedr had a problem deploying to ia-pensions-fix-email-s-am3ywi October 12, 2023 19:53 Failure
@xmedr xmedr temporarily deployed to ia-pensions-fix-email-s-am3ywi October 12, 2023 20:01 Inactive
@xmedr xmedr temporarily deployed to ia-pensions-fix-email-s-am3ywi October 12, 2023 20:24 Inactive
@xmedr xmedr requested a review from fgregg October 12, 2023 20:26
@xmedr xmedr merged commit 7ada0c3 into main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants