Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[01] solve somes ruff exception in code quality #87

Merged
merged 13 commits into from
Mar 7, 2024
Merged

[01] solve somes ruff exception in code quality #87

merged 13 commits into from
Mar 7, 2024

Commits on Mar 5, 2024

  1. fix: PTH120 os.path.dirname() should be replaced by Path.parent

    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    712551b View commit details
    Browse the repository at this point in the history

  2. fix: bloom/config.py:13:97: E501 Line too long (130 > 96 characters)

    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    de03dbe View commit details
    Browse the repository at this point in the history

  3. fix: almebic create_amp_table F821 Undefined name Inspector & E501 … 

    …Line too long (107 > 96 characters)

alembic/versions/961cee5426d6_create_amp_table.py:30:97: E501 Line too long (107 > 96 characters)
alembic/versions/961cee5426d6_create_amp_table.py:37:17: F821 Undefined name `Inspector`
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9562f21 View commit details
    Browse the repository at this point in the history

  4. fix: vessel_trajectory Private member accessed: _mpas 

    bloom/domain/vessels/vessel_trajectory.py:125:13: SLF001 Private member accessed: `_mpas`
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    32827b8 View commit details
    Browse the repository at this point in the history

  5. fix: repository_alert E101 Indentation contains mixed spaces and tabs 

    bloom/infra/repositories/repository_alert.py:26:1: E101 Indentation contains mixed spaces and tabs
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7af8639 View commit details
    Browse the repository at this point in the history

  6. fix: marine_traffic_usecase is commented so commented all reference… 

    …s. Why is commented ?

app.py:37:22: F821 Undefined name `marine_traffic_usecase`
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0c33c61 View commit details
    Browse the repository at this point in the history

  7. fix: set typehint for mpas setter 

    bloom/domain/vessels/vessel_trajectory.py:89:9: ANN202 Missing return type annotation for private function `mpas`
bloom/domain/vessels/vessel_trajectory.py:89:20: ANN001 Missing type annotation for function argument `value`
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f2d3422 View commit details
    Browse the repository at this point in the history

  8. fix: repository_alert.py:24:97: E501 Line too long. Request must be t… 

    …ested

 bloom/infra/repositories/repository_alert.py:24:97: E501 Line too long (288 > 96 characters)
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    759021f View commit details
    Browse the repository at this point in the history

  9. fix: ruff exception Trawlwatcher.py on exception 

    Trawlwatcher.py:15:11: TRY003 Avoid specifying long messages outside the exception class
    @rv2931
    rv2931 authored and herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4453b2c View commit details
    Browse the repository at this point in the history

  10. Revert "fix: repository_alert.py:24:97: E501 Line too long. Request m… 

    …ust be tested"

This reverts commit b3c673e.
    herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1029ceb View commit details
    Browse the repository at this point in the history

  11. fix: try ignore ruff E501 line too ong with # noqa E501

    herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e0ca5a2 View commit details
    Browse the repository at this point in the history

  12. fix: migrate poetry.lock, pyproject & tox at root after folder redesign

    herve.le-bars committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f567e5d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. clean

    herve.le-bars committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1d25b30 View commit details
    Browse the repository at this point in the history