Frontend update 623ab16 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanega J'ai fait une version plus adaptée au dev pour le front
|
rv2931
force-pushed
the
frontend_update_623ab16
branch
5 times, most recently
from
4597483
to
10f7d1c
Compare
rv2931
force-pushed
the
frontend_update_623ab16
branch
from
10f7d1c
to
75767ea
Compare
rv2931
force-pushed
the
frontend_update_623ab16
branch
from
75767ea
to
da9b098
Compare
rv2931
force-pushed
the
frontend_update_623ab16
branch
2 times, most recently
from
a17848c
to
e4f8c94
Compare
…les missing Because frontend needs frontend build that is done during building docker, mounting volume for dev removes this building Entrytpoint could be modified to detect that frontend needs to be rebuild but for the moment, removing volume mounting to assure frontend works
# Conflicts: # docker/Dockerfile
# Conflicts: # docker-compose-load-data.yaml
…les missing Because frontend needs frontend build that is done during building docker, mounting volume for dev removes this building Entrytpoint could be modified to detect that frontend needs to be rebuild but for the moment, removing volume mounting to assure frontend works # Conflicts: # docker-compose.yaml
# Conflicts: # docker-compose.yaml
rv2931
force-pushed
the
frontend_update_623ab16
branch
from
e4f8c94
to
076eccd
Compare
|
Procédure pour le lancement d'une stack complète from scratch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mise à jour du frontend à partir du dépôt de @tanega (https://github.com/tanega/trailwatch-front-kickoff/)
Version courante : main/commit 623ab16
Ajout d'un ignore frontend/public/data pour éviter d'indexer/visualiser des data
L'idée étant d'intégrer une ultime version permettant au front de travailler directement dans le dépôt commun à partir de maintenant
Pour la partie dev embarquée au sein du conteneur Docker, je pense qu'il va falloir éclaircir une meilleure manière de faire
En effet j'ai l'impression que les dev actuels développent hors docker et une app JS devant plutôt être compilée, le montage d'un volume de développement au sein du conteneur nécessite une recompilation au sein du conteneur.
Ce point d'un conteneur docker permettant et le déploiement et le développement est à rediscuter sur la manière de faire mais ne fait pas partie de cette PR